Closed Bug 1612981 Opened 5 years ago Closed 5 years ago

WebGLContextGL.cpp: MatrixAxBToRowMajor is not used

Categories

(Developer Infrastructure :: Source Code Analysis, task)

task
Not set
normal

Tracking

(firefox75 fixed)

RESOLVED FIXED
mozilla75
Tracking Status
firefox75 --- fixed

People

(Reporter: Sylvestre, Assigned: virresh, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: good-first-bug, Whiteboard: [lang=C++])

Attachments

(1 file)

Filling as a good first bug to learn workflows.

https://searchfox.org/mozilla-central/source/dom/canvas/WebGLContextGL.cpp#1266-1275
but not called anywhere.

As the change is trivial, it is just to learn how to contribute to Firefox.

Found by clang diag https://clang.llvm.org/docs/DiagnosticsReference.html#wunused-function

Tutorial to contribute:
https://firefox-source-docs.mozilla.org/tools/docs/contribute/how_to_contribute_firefox.html

Remove unused code from dom/canvas/WebGLContextGL.cpp

Assignee: nobody → viresh16118
Status: NEW → ASSIGNED

Hello Sylvestre,
I am new around here and saw this as good-first-bug.

I was asked by moz-phab for reviewers so I put in your nickname. My apologies if I was incorrect. Please let me know the correct way to find reviewers. (There are a lot of people who have worked on reviewing the previous commits on WebGLContextGL.cpp).

Looks great, bravo :)

Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla75
Product: Firefox Build System → Developer Infrastructure
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: